Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve OVAL and tests for accounts_password_pam_unix_authtok #12868

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

mpurg
Copy link
Contributor

@mpurg mpurg commented Jan 22, 2025

Description:

  • Added a condition that at least one pam_unix must exist in PAM password file
  • Cleaned up the IDs and comments in OVAL
  • Added test scenarios for missing pam_unix line and for commented parameter use_authtok

mpurg added 2 commits January 22, 2025 09:56
- added condition that at least one pam_unix must exist in PAM password file
- cleaned up ids and comments
@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Jan 22, 2025
Copy link

openshift-ci bot commented Jan 22, 2025

Hi @mpurg. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

This datastream diff is auto generated by the check Compare DS/Generate Diff

Click here to see the full diff
OVAL for rule 'xccdf_org.ssgproject.content_rule_accounts_password_pam_unix_authtok' differs.
--- oval:ssg-accounts_password_pam_unix_authtok:def:1
+++ oval:ssg-accounts_password_pam_unix_authtok:def:1
@@ -1,2 +1,3 @@
 criteria AND
-criterion oval:ssg-test_password_pam_unix_use_authtok:tst:1
+criterion oval:ssg-test_accounts_password_pam_unix_authtok_pam_unix_exists:tst:1
+criterion oval:ssg-test_accounts_password_pam_unix_authtok_prm_exists_not_initial:tst:1

Copy link

codeclimate bot commented Jan 22, 2025

Code Climate has analyzed commit 305e6fd and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 61.9% (0.0% change).

View more on Code Climate.

@dodys dodys added this to the 0.1.76 milestone Jan 23, 2025
@dodys dodys added Test Suite Update in Test Suite. OVAL OVAL update. Related to the systems assessments. labels Jan 23, 2025
@dodys dodys self-assigned this Jan 23, 2025
Copy link
Contributor

@dodys dodys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@dodys dodys merged commit 38af1cc into ComplianceAsCode:master Jan 23, 2025
92 of 100 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test Used by openshift-ci bot. OVAL OVAL update. Related to the systems assessments. Test Suite Update in Test Suite.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants